PS-11417: Enforce the wildcard-subject guard in the GitHub OIDC module#366
Merged
Merged
Conversation
…module - Add a validation rejecting * and ? in subject_claims, making the 'forbids them at the API' comment true instead of aspirational - StringEquals keeps wildcards inert either way; the gate now blocks them at plan time with a clear message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
github-oidc-rolemodule documents that wildcard subject claims are "forbidden at the API", but its only validation rejects empty listsStringEqualskeeps a wildcard inert either way, so there is no live exposure; the documented gate was aspirationalFix
subject_claimsvalidation rejecting*and?, failing at plan time with a clear messageTickets